@pRicard0
Posted
Yo! So... I'll try to answer your questions
- From my point of view, your
<section>
is wrong. When our project needs a<section>
, we expect more than one. For example... image section, text section, etc... You should at least wrap your<div class="attribution">
with a<section>
. By doing so, I think your project will still be wrong because your card should be your<main>
tag and you should use<footer>
instead of<div class="attribution">
. Header and footer should not be included inside the<main>
tag. Summing up, remove the<section>
tag and your<footer>
should be outside the<main>
tag - Your id is okay, you don't need to specify more than that. This is just a simple project
- You should try using rem instead of em
Marked as helpful