Skip to content
OverviewSolutions
1
Comments
8
Adeline
@AdelineSey

All comments

  • DEDI•70
    @DEDI308
    What are you most proud of, and what would you do differently next time?

    I was proud that even though it took me a long time to make something simple, I knew what each attribute did and the design turned out well.

    What challenges did you encounter, and how did you overcome them?

    positioning, heights and widths. I had to use several paddings, flex, gaps and margins and I was still in doubt if it was the right way.

    What specific areas of your project would you like help with?

    I would like to know if the amount of codes and classes I used is valid or if it was possible to do something much simpler than that. In addition to knowing if I could use some other attribute instead of those used.

    Qr code brabo

    1
    Adeline•70
    @AdelineSey

    Knowing what each part does is so important and it's awesome that you know what each part of your code is responsible for! I checked out your live site and it matches up with the reference photo really well. The background color is really pretty <3

    Minor notes:

    • Line 14: Your alt="" is missing the image description text.
    • Line 17: Small spelling error on 'building'.

    I don't have any tips on #'s of codes/classes, but I think you did an awesome job and should be proud of yourself 🙂

    Marked as helpful
  • StickyStick35•10
    @StickyStick35
    What specific areas of your project would you like help with?

    I would like to get a feedback over all my project

    QR Component

    2
    Adeline•70
    @AdelineSey

    Overall, it looks great! The colors and alignment of your live site match the reference photo well.

    Few things I'd adjust in your code:

    • Line 12: Your <div> opening tag is missing the </div> closing tag.
    • Line 14: Your image alt is empty and should have a brief description of the image.
    • Line 16: Your opening tag is <h4> but your closing tag is </h2>. They should both be the same h-number.

    Hope this helps 🙂

  • Jyogita•70
    @Jyogita
    What are you most proud of, and what would you do differently next time?

    I'm proud of successfully completing this challenge with clean, accessible, and user-friendly code, and next time, I aim to improve my efficiency by completing it in less time.

    What specific areas of your project would you like help with?

    I’d appreciate any feedback on how I can make my code cleaner, more efficient, and match the design more accurately.

    Qr Code Component

    2
    Adeline•70
    @AdelineSey

    Your HTML, CSS, and live site all look great! If you ever want to make your code easier to read and decipher, adding comments is super easy. To add a comment on your index.html page do this <!-- Example Text -->, and to add a comment on your style.css page do this /* Example Text */

    I find adding comments really helpful for labeling what different parts of my code are for. It's especially helpful for when I take long breaks because I don't have to try so hard to remember what I was doing lol.

    Only thing I'd recommend changing in your code is replacing the # on line 39 with a URL to your profile. Awesome work!

  • Adeline•70
    @AdelineSey

    Overall, a great attempt! I checked your live site and, unfortunately, it seems to be missing the white box and the background color. A couple things that I noticed:

    • The <div> opening tag on line 22 is missing its closing tag (</div).
    • The <a href> opening tag on line 32 is missing a URL.
    • The .card-container on your stylesheet (line 12) is missing a background color, which might be why the white background behind the QR code image isn't showing on your live site.
    • I would add a class="body" to the <body> opening tag on line 19, then on your style sheet, you can assign the page background color for that class.

    Hope these suggestions make sense. Keep up the good work!

  • 6alactico•470
    @6alactico
    What are you most proud of, and what would you do differently next time?

    I am proud of using my CSS knowledge to align the card and its elements in the middle of the screen. I am unsure what I would do differently next time, but as I continue learning CSS, I can probably achieve the card design using fewer elements.

    What challenges did you encounter, and how did you overcome them?

    N/A

    What specific areas of your project would you like help with?

    I am open to any criticism.

    QR Code Component

    1
    Adeline•70
    @AdelineSey

    Your finished project looks great! I looked over your code and everything seems well thought out and planned. If I had to make one suggestion, make a separate stylesheet (style.css) so that way your HTML and CSS code each have their own spot. I've found it makes my code a lot easier to read, especially from someone else's perspective. If you ever want to notate different sections, adding comments is easy and helpful. HTML comments are formatted <!-- Example Text --> and CSS comments are formatted /* Example Text */. Great job!

    Marked as helpful
  • Adeline•70
    @AdelineSey

    Your code and final product look awesome! I am very new to coding and learned some new techniques reading through your code. One thing I really appreciate is the separating comments to make your code easier to follow, it's very helpful!

    Only thing I'd change - update the # in the last <a href="" so it will link to your profile 😊

  • Adeline•70
    @AdelineSey

    Final product looks great, and your code is pretty easy to read! If I had one critique, it looks like there are a couple of classes that are on your HTML code but weren't necessary for your stylesheet. It might be easier to only include classes needed for styling and leave off the extras. Overall, great job!

    Marked as helpful
  • Floydbk•10
    @Floydbk
    What are you most proud of, and what would you do differently next time?

    the fact that i understand git and github abit more i would like to learn more about CSS

    What challenges did you encounter, and how did you overcome them?

    CSS and i had to use youtube and deep seek to solve my code

    I used Html and CSS

    1
    Adeline•70
    @AdelineSey

    Great effort! I had to watch a YouTube video as well so I could figure out GitHub, setting up repositories, and using the terminal. If you are looking for good learning resources, I find MDN Web Docs to be very helpful. They have info on all sorts of stuff, and I referenced it many times during this project.

    I wasn't able to preview your code as the link appears to be broken, but from looking at the final product, most of my critiques would be about sizing which is a minor thing imo. The fact that you were able to get everything positioned well is great!