All comments

• 

  Muhammad Zubair• 50

  @iAmZubair00

  Submitted over 2 years ago

  Please go through my solution and give suggestions around:

  1. any bug in the live site
  2. accessibility issues in HTML
  3. issues in the approach of writing Sass (as I have used Sass very 1st time!)
  4. and any other constructive feedback.

  

  Sign Up form built using HTML, CSS, Javascript and Sass

  2

  1

  0

  

  Al-Baraa Bakri• 330

  @Al-Baraa-Bakri

  Posted over 2 years ago

  Good Job :) I think there is no need to scroll on big screens.. More Smooth without this scroll .. And You Need To Fix ACCESSIBILITY ISSUES By use Landmarks. Keep Coding :)

  0
• 

  LEUILLIER• 120

  @JulienLEUILLIER

  Submitted over 2 years ago

  Second FrontEndMentor challenge completed !

  I complicated things at first by trying to make the images responsive in size with the screen width, to be able to have a flexible width for mobile. I ended up just leaving a fixed size but learned some awesome ways to get responsive images ! I also tried to implement BEM to get some, I think, clean and maintainable SCSS code.

  Any comment would be highly valued !

  

  Responsive accordion layout; SCSS with BEM

  3

  3

  0

  

  Al-Baraa Bakri• 330

  @Al-Baraa-Bakri

  Posted over 2 years ago

  good job :) I just finished this challenge .. What About Add Some Transition ?

  1

  This comment has received 1 replyShow