@gtarrojo
What specific areas of your project would you like help with?
Feedback will be great!
Latest solutions
Proyecto de suscripción a newsletter
#accessibilitySubmitted about 2 months agoTo be honest, I still need a great deal of practice, especially with JavaScript. There are many methods I’m not yet familiar with, which often causes me to get stuck. I spent quite a bit of time figuring out how to use event.preventDefault it was a challenge, mostly due to syntax errors. Nevertheless, I’m ready to move forward to the next project
Built with HTML, CSS Grid, and JavaScript. Fully responsive.
Submitted 3 months agoI would like some advice on JavaScript, even though I've written only a little bit of JavaScript, it's what I struggle with the most.
Latest comments
- @EDrick-her
Hi! To be honest, I don’t understand the project very well because I don’t know Angular or JSON, and there are a lot of folders whose purpose I’m not familiar with. So I’ll just suggest a few things based on what I do know and areas I believe you can improve on:
The most important thing here is the form. You can build it natively using HTML so that, when the user enters an incorrect email, the browser will automatically show an error and prompt them to enter it correctly.
Additionally, you could also use JavaScript with a regular expression (regex) to validate the email input, like this: const emailUsuario = document.getElementById("email").value; const emailValido = /^[^\s@]+@[^\s@]+.[^\s@]+$/.test(emailUsuario); This code grabs the email the user enters and performs a simple validation check.
I mention this because, in your current implementation, I was able to enter something like hi@h and it still let me through even though hi@h isn’t a valid email (it’s missing a domain like gmail, hotmail, outlook, etc.).
Lastly, I noticed some minor issues with hover effects when clicking the button. But honestly, I couldn’t locate the specific problem due to the number of folders again, that’s on me. I’m just not sure why there are so many files.
- @3zefir@EDrick-her
There are too many <div> elements in the HTML. Try to use semantic tags to make it more readable, like <article>, <footer>, and <section>. The design is not centered and it's not responsive. I think you used position: relative for everything, but you could have used flex or grid. I would recommend using grid, but that's just because I find it easier, especially for handling @media (media queries). I would recommend using an extension or tool to help you get the exact colors you're working with so you can match them properly. I liked the button animation, but it only happens on the first click. After that, it doesn't appear again, and when you click it, it creates a type of horizontal scroll that shouldn't be visible. I loved your GitHub; I think you manage it well, unlike mine, which is a mess haha. That's all. If you need anything I can help with, just let me know. Take care!
