Skip to content
OverviewSolutions
13
Comments
10
Ahmed
@Kirin02

All comments

  • Ahmed•105
    @Kirin02

    The Link to your live page doesn't work, but on a quick scan on your code, i noticed you put font-weight: 900; but you only imported 400 and 700 font-weights, other than that i recommend you check other sizing units other than px like (em, rem..)

    Marked as helpful
  • Ahmed•105
    @Kirin02

    Hey, i'd say try to make the submit button hover animation a bit more interesting i would say, the position of the image is kinda odd i'd say espcially since it got sharp edges i would say move it to the extreme right or limit the height or something if you use inspect tool you'll find that it overflowing from the <body> Also It highly unrecommended to Use !important other than that i like the mobile display it looks really good but i think you can improve the desktop one a bit more

  • Ahmed•105
    @Kirin02

    i would recommend that you study more flexbox so that you avoid positionning you elements using top and right and float with specfic use of px which made ur H1 and Description collapse into each other and media queries to make your website responsive on most devices

    Marked as helpful
  • Ahmed•105
    @Kirin02

    Good Job! I would say avoid using width and height properties too much espcially with px, your website is responsive but i think on the long way when you code other websites it might create some troubles for you.

    Marked as helpful
  • Ahmed•105
    @Kirin02

    Good Job!

  • Ahmed•105
    @Kirin02

    First thing first, About your HTML you should Check semantic HTML and apply it, also it better if you could link the font on your CSS Using @import and you spammed many properties many times like font-family, font-size, font-weight, flex.... also the card isn't properly centered and using flex in body is a bad move i would say

    Marked as helpful
  • Ahmed•105
    @Kirin02

    I Think Your code is pretty clean, but i would suggest adding some hover transition unto the button or the anchor tag, Good job!

  • Ahmed•105
    @Kirin02

    Fantastic work claps

  • Ahmed•105
    @Kirin02

    Hello, You did a mistake in the border-top-left-radius i believe you wanted to target border-bottom-right-radius !

    Marked as helpful
  • Ahmed•105
    @Kirin02

    I don't think it was "hacky" i feel like the code just looks pro but i feel it could be much more simplified, also you have some useless properties if you inspect with your browser you'll find some of them who aren't doing anything like " margin: 0 auto" ...

    Marked as helpful