Loris Bettazza
@PusturAll comments
- @JesusAtao96@Pustur
Congrats, you got very close to the design 👏
I would remove the border-left from the cards that are not "featured", but otherwise it looks great.
Nice animations too, keep it up 😉
- @sakthi0314@Pustur
You put the wrong url in the solution, it should be https://sakthi0314.github.io/Frontend-metor-challages/loopstudios-landing-page-main/src/
- @aaronpaulgz@Pustur
Good work so far, a few improvements I would make:
- No focus style for the text input and submit button, consider adding some or leave the default outline so keyboard users have an easier time knowing where they are focused :)
- When clicking the submit button with an invalid input, an error appears, but it shouldn't continue creating new error messages when I try to submit multiple times. Consider making a single element for the error and just show / hide it when necessary.
- Impossible to scroll the page and see all the content when the browser window is small vertically.
- @AndyBeable@Pustur
Hey Andy,
Hover underlines on links in main nav and footer. I did manage to get this working, but for some reason the line would only show up in one place, not under each link. So i've removed for now.
Sounds like you positioned the lines with
position: absolute;
but the links didn't haveposition: relative;
? So they were all relative to some other common parent element. If that's the case you should addposition: relative;
to your links.Would like to add some hover states to the creations tiles, but again couldn't figure it out.
I did it using
::before
and::after
, one was for a black gradient to improve readability of the white text, the other is a white overlay that shows up on hover/focus. I did this with theposition: relative;
in the parent andposition: absolute;
in the pseudo element.The 'See all' cta, on desktop, I wanted to move it to the top right of the section as per the design, but could only seem to do that using absolute positioning and then that caused issues when the screen-size changed.
I used grid and the
order
property for this, I agree usingposition: absolute;
can sometimes get messy.Good work overall, I like the animations on scroll. (Too bad they mess up the screenshot 😅)
Check out my solution if you want to see how I did the things you asked about.