Neerajkumar-webโข 160
@Neerajkumar-web
Submitted
All Feedback are welcome, thank you
Abhishek choudhary
@dazzlerabhi30800
All comments
- Abhishek choudharyโข 1,570
@dazzlerabhi30800
Posted
Congrats for completing the challenge but the image hasn't been loaded. I think instead of github as beginner try deploying you project on netlify or vercel as it is easier to deploy and they provide a very optimized build. When email format is incorrect it should show a error message you can do it by placing the label tag after input or any other tag to show like input[type="email"]:invalid ~ label { opacity : 1; } and Lastly use link/import tag to to use google fonts instead of including the font file in your project.
0 - FocusSTmattโข 170
@FocusSTmatt
Submitted
-
Is it best practice to separate Component styles in their own CSS file? if not, what is the proper way of going about this?
-
I'm not sure if my code is structured properly here. I was practicing passing props and state to components and I think I may have added unnecessary layers of complexity by adding components when it may not have been needed. I'm curious what the textbook code structure would have been for this little app?
Any comments or suggestions are welcome. Thanks!
Abhishek choudharyโข 1,570@dazzlerabhi30800
Posted
You could have made only two component: 1: The Main NewsLetter Component 2: Thank you Component That's all you need but still your solution clean btw. You could place them in the separate folder for main and thank you Comp if your using > 2 Components for export And last on clicking the dismiss button the main comp should be visible again.
Marked as helpful
0 -
- Abhishek choudharyโข 1,570
@dazzlerabhi30800
Submitted
Abhishek choudharyโข 1,570@dazzlerabhi30800
Posted
Need Feedback to make my solution better.
0 - Ebsa Alemuโข 310
@burningorc
Submitted
if you have any feedback or tips, please let me know
Abhishek choudharyโข 1,570@dazzlerabhi30800
Posted
for html issues just one level heading at a time like h1, h2 then h3. This will solve the Accessibility issue.
0 - Alienโข 50
@Alienowy
Submitted
That was my first try to code a design.
Is my code is good? What schould I do better?
Any feedback would be great.
Abhishek choudharyโข 1,570@dazzlerabhi30800
Posted
Congrats on completing the challenge. First Issue I would like to address is instead of giving min-width to body and give it to template qr & second to solve the accessbility issues first wrap the template qr inside main tag and attribute container inside footer tag.
Marked as helpful
0 - Luboลก Brรคthโข 630
@Bredis79
Submitted
Abhishek choudharyโข 1,570@dazzlerabhi30800
Posted
After writing the email in correct format input should update the state, as it's still showing error.
Marked as helpful
0 - dmcdaniel90โข 60
@dmcdaniel90
Submitted
What best practices do you have for systematically working through any project?
Abhishek choudharyโข 1,570@dazzlerabhi30800
Posted
First plan the layout of html, then style using CSS. Second if you have problem in designing layout use google. Last after completing the project do it again from scratch.
0 - Alexander Charles Bonneyโข 530
@alexanderbonney
Submitted
Abhishek choudharyโข 1,570@dazzlerabhi30800
Posted
Congrats loved your solution๐๐
0 - Abhilashโข 920
@Chiku100
Submitted
How do I remove errors when I start to fill the form after getting errors due to empty input and other feedback also helps a lot :)
Abhishek choudharyโข 1,570@dazzlerabhi30800
Posted
you can use onchange property on each input
0 @MarielaNina
Submitted
Abhishek choudharyโข 1,570@dazzlerabhi30800
Posted
Congrats on completing the challenge๐๐. Use Pseudo selector on NFT image and set opacity to 1 while hovering over it.
0- rykryslrโข 100
@chigyong
Submitted
Comments & Feedbacks are appreciated :)
Abhishek choudharyโข 1,570@dazzlerabhi30800
Posted
center the div using min-height: 100vh; on body tag and use flex property with justify-content: center; and align-items: center;
Marked as helpful
1 - Albaโข 70
@albscr
Submitted
This is my third challenge and these are some of the problems I faced and I think I didn't solve them as I should have: -I didn't know how to align the three buttons to be horizontally equal (what I did was to modify the margin of each button). -In the last challenge I had problems with making the page responsive, according to me I did it but I received comments that it wasn't. I don't know if in this challenge I made it but I hope your comments about it (I check that it is for the different devices in chrome - inspect). -I eliminated the attribution at the end because I did not know how to position it below (it was on the container and I tried position without success).
I look forward to your always useful feedback thanks
Abhishek choudharyโข 1,570@dazzlerabhi30800
Posted
Congrats!!
- Use h1, h2 then h3 to take care of Accessbility Issues
- use border: 2px solid transparent; on .btn to fix the design shifting issue on hover! Thank you Namaste๐
0 - rykryslrโข 100
@chigyong
Submitted
All feedbacks are well appreciated :) Happy Coding !
Abhishek choudharyโข 1,570@dazzlerabhi30800
Posted
Congrats on finishing your first challenge!๐๐
- To center your component give body a min-height of 100vh and display: flex; justify-content: center, align-items: center; - this will center the card horizontally and vertically.
- Wrap you whole .container inside main tag
- Heading levels should be raised by one h1, h2 and so on, use h1 instead of h3 or span this will take care of Accessbility issues. HAPPY CODING.๐๐๐
Marked as helpful
1 - Anette23โข 400
@Anette23
Submitted
Abhishek choudharyโข 1,570@dazzlerabhi30800
Posted
in the second section of class "info" you should use div instead of wrapper so your html issues can be solved. Although your solution is awesome๐๐
Marked as helpful
0 - ๐พ Ekaterine Mitagvaria ๐พโข 7,640
@catherineisonline
Submitted
Hello, Frontend Mentor community! This is my solution to the Crowdfunding product page.
I appreciate all the feedback you left that helped me to improve this project. Due to the fact that I published this project very long ago, I am no longer updating it and changing its status to Public Archive on my Github.
You are free to download or use the code for reference in your projects, but I no longer update it or accept any feedback.
Thank you
Abhishek choudharyโข 1,570@dazzlerabhi30800
Posted
I loved the digit incrementing animation๐๐.
0 - Rafael Eliasโข 290
@RafisElias
Submitted
any suggestions on how i can improve my code i'm welcome
Abhishek choudharyโข 1,570@dazzlerabhi30800
Posted
Your design is absolute good and congrats on completing the challenge. Your css is very clean and I don't think there is something to fix other than HTML issues.You should use at least one heading in project to fix it. Nice Project๐
1 - Achinta Haldarโข 140
@FSwebdeveloper
Submitted
All Feedback is Well Come.
Abhishek choudharyโข 1,570@dazzlerabhi30800
Posted
Put your whole component inside main tag and use heading levels raised by one only that will take care of the accessibility issues.
0 - Tan Nguyenโข 160
@TanNguyen17112003
Submitted
So happy to overcome this challenge
Abhishek choudharyโข 1,570@dazzlerabhi30800
Posted
Put your container inside main tag and your accessibility issues will be solved. use justify-content: space-between on the '.contain-desc' to align the text in center with the image.
0 - Luis Oliveroโข 170
@Luis-Olivero
Submitted
2nd attempt, what else can I improve on?
Abhishek choudharyโข 1,570@dazzlerabhi30800
Posted
Try changing the font size in smaller screens, put your container inside main tag and lastly use h2 instead of h4 or you can use span tag also.This will take care of the responsiveness and accessibility issues.
Marked as helpful
0 - Jeferson Mesaโข 60
@jefersond91
Submitted
I would like to know your points of view and feedback to get better my code. thanks a lot.
Abhishek choudharyโข 1,570@dazzlerabhi30800
Posted
Your solution is good overall but when you hover on button the design shifts you can solve by giving border: 2px solid transparent on button and change the border color you desired on hover, second issue is to solve the accessibility issues by using h1 first and then h2, h3, h4. Hope this helps my english isn't much good
0 - Aung Ko Ko Khantโข 30
@aungkokokhant16
Submitted
I try my best. I am a newbie. Pls check my solution and tell me back what I need
Abhishek choudharyโข 1,570@dazzlerabhi30800
Posted
Your solution is good as well as code the only thing you need is to solve the accessibility issues by wrapping the whole component inside main tag.
0 - MirTynanโข 100
@MirTynan
Submitted
This is an issue that I just can't seem to solve, with height and width and max-height and width, or 100vh and 100vw in any project. There must be something basic that I am doing wrong. I want to start my next course, I'm studing at home to try train as a developer but don't want to start without being able to do something this basic. Can anyone please help me? Have a look and see what it is that I am doing wrong or what it is that I don't understand. The problem in this project is when we reach the mobile size in responsiveness. So below 544px. I can't get the background image to fill the screen. Thank you.
Abhishek choudharyโข 1,570@dazzlerabhi30800
Posted
Congrats on completing the project Now changing the design on media query max width: 34em change the .background-img properties as following: height: 100vh, max-height: 100vh, width: 100vw, max-width: 100vw, bottom: initial, margin-left: initial, margin-right: initial, background-size: cover
Marked as helpful
0 - Glowโข 140
@TheAwesomeTechGirl
Submitted
I couldn't get the styling for the active state, please can I get a correction on that? And can I please get a correction on my mobile if any?
Abhishek choudharyโข 1,570@dazzlerabhi30800
Posted
Ok this 1st - about the design - You should change the body background color to some dark color, 2nd - instead of using margin top property you should use align-items: center 3rd - instead of flex property on container you should use grid property that will fix the overflow of design 4th - to fix accessibility issues you should wrap the whole container inside main tag! 5th - most important your approach should be mobile first. Thank You and have a good day!
Marked as helpful
0 - Luke Satchwellโข 310
@Luke-Satchwell
Submitted
I'm relatively new to this- this was my first personal project!! How would a more experienced dev look to organise their CSS so it was in a single file? What tips would you give a noob??
Abhishek choudharyโข 1,570@dazzlerabhi30800
Posted
Nice work! try using JS for the dynamic image and content and also try decreasing the width of descriptive paragraphs. Site's not responsive but still very good for a First Project.
0
