Peter Forster
@peterforster10All comments
- @osmarmcn@peterforster10
looks good except for the spacing between the cards
- @m-abubakr1What are you most proud of, and what would you do differently next time?
Got to learn about the Regex in JavaScript, hoping it may help in the long term. Next time, I will be trying to use some 3rd party Apis of js for validation.
What challenges did you encounter, and how did you overcome them?The most challenging part was to give styling to the input focus in a way that it fulfills the requirements. I got to know how multiple styling can be added through JS
What specific areas of your project would you like help with?Object.assign()
function, but the best way to do it was to just add or remove classes.Any Suggestions on how to get precise margins and paddings without spending hours on experimenting?
@peterforster10Looks very good!
- @Aldeeb2020@peterforster10
looks very good except for the missing border-radius on the card
- @AceThunder546@peterforster10
looks quite nice
- @elMarMarWhat are you most proud of, and what would you do differently next time?
I'm proud that my solution seems pretty spot-on. However, I think my code is a little disorganized since I'm still learning flexbox. As I continue to learn flexbox's properties, I believe I'll be able to more elegantly and efficiently code these front end sites.
What challenges did you encounter, and how did you overcome them?I still don't perfectly understand certain flexbox properties. For example, flex-basis is still a fuzzy concept for me. It's the default size of an element based on what? When does it shrink/grow from that size.
What specific areas of your project would you like help with?I would like to know if I used flexbox efficiently. Sometimes it feels like I'm abusing flexbox, but I'm struggling to my head around other methods that could better position my elements.
@peterforster10looks quite good
- @Azai4What are you most proud of, and what would you do differently next time?
Going through this challenge and solving the problems smoothly
What challenges did you encounter, and how did you overcome them?the display in the desktop screen size when using the media queries
What specific areas of your project would you like help with?media queries for larger screen sizes
@peterforster10Try to be more precise when implementing the design
Marked as helpful - @NatentadoWhat challenges did you encounter, and how did you overcome them?
My main challenges are related to metrics sizes and specific colors used as i do not own a pro signature to inspect the design layout.
@peterforster10Looks very nice except for the background color of the rose box.
Marked as helpful - @Heriniaina-30What challenges did you encounter, and how did you overcome them?
Now, I understand how to use the flexbox
@peterforster10Looks nice! But the padding of the card is little too big.
- P@amyspencerprojectWhat are you most proud of, and what would you do differently next time?
Getting back to Frontend Mentor after a year-ish long pause. I am sure there will be some issues because I am a little rusty.
@peterforster10Looks good except that the card is not vertically centered. And the color of the subtitle is not light gray.
- @MalachifullertonWhat are you most proud of, and what would you do differently next time?
What I am most proud of accomplishing in this project is finally becoming comfortable with the basic git commands and finally understanding commit messages and how it works
What challenges did you encounter, and how did you overcome them?I encountered a few challenges but below are some of them:
- I faced the problem of my html body container not filling the whole screen and I solved that by adding ```css html, body { height: 100%; }
What specific areas of your project would you like help with?2) Another challenge I faced was with the sizing of containers which was solved with ```css * { margin: 0; padding: 0; box-sizing: border-box; }
-
The first question I want to ask is about the .attribution section in the html file... is it supposed to be at the base of the page or it can sit right under the QR code and text housing container?
-
The next question is about the sizing of the container that houses the qr-code and texts... in the figma file it looks bigger than the solution image provided in the project by frontendmentor. This can be seen through the top spacing between the qr-code image and the border of the container in question.
@peterforster10- Looks quite good
- But check padding of your card component
- And check the color of card component title
- And the box shadow is missing of the component