@emestabillo
Posted
Hey Emily, looks great! Site is responsive and close to the design. I think adding and hiding the h1 is a good call for accessibility. I only have a few thoughts:
-
Missing CSS reset. The body has an 8px margin all around that's producing vertical scrollbar (apparent especially on desktop)
-
Not sure why
main
has an id. I don't see it being used in the project. Using the class for styling should be enough. -
I think there may be a better html tag for the car types instead of
section
. The 3 cards are related, and they seem like they represent an entire region of a document together. Maybe a generic div? This is subjective, of course. -
one other minor thing is adding a transition to the button to make the hover smoother
Hope this helps!
Marked as helpful
@emilyw12
Posted
@emestabillo Thanks so much for the feedback!