Hey @xolott 👋🏻
I have some suggestion to help you fix the accessibility, HTML and some other issues
- Instead of
<section>
, I suggest using regular<div>
for a couple of reasons. First, when you use a<section>
you have to have a heading, likeh1-h6
. Next,<section>
is for bigger parts of layout, such as, contact us about us, image gallery, etc. This will help you fix the HTML issue, but don't forget to generate a new report once you push the changes to GitHub. - What comes to accessibility, the car icons, should have
aria-hidden="true”
, because they are for decoration. For example,<img src="/static/media/icon-sedans.e7945028.svg" aria-hidden="true”>
. You can read more aboutaria-hidden
here.
I hope this was helpful 👨🏻💻 For the second project, you did a pixel perfect job, well done. Cheers 👾
Marked as helpful
@xolott
Posted
Thanks, @kens-visuals
Really appreciate your feedback. I applied your suggestions. There is only 1 error left about the h1
element, but I think this is an acceptable error for this challenge. Do you know any possible fix?
No problem @xolott ✌🏻
I believe it's because your headings are in h2
try to put them in h1