@vanzasetia
Posted
👋Hi Mason!
Like Manikandan has said, on mobile everything is overflowing. Try to fix this layout issue.
I have some feedback on this solution:
- You should wrap all your page content, except the attribution with
main
tag. - For the attribution, you can swap the
div
withfooter
tag. - Only have one
h1
for every page. It's a good practice and good for accessibility. Also the Rated 5 stars..., should not be headings. - Avoid inline styling! It can create a lot of issues, especially on bigger project.
- Heading order is extremely important. You need to use
h1
,h2
,h3
, and so on. Remember don't use heading for making the text bold and smaller. - You might want to use
strong
orem
tag instead of heading tags. - For the
comment
, I recommend to useblockquote
to make it more semantic. - Always set all elements to
box-sizing: border-box
to prevent unexpected things when you're addingpadding
. - Use
rem
or sometimesem
instead ofpx
. Usingpx
will not allow the users to control the size of your page based on their needs.
That's it! Hopefully this is helpful!
Marked as helpful
@mrcrist2526
Posted
@vanzasetia This was very helpful. Thanks a ton!