Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

A desktop/mobile compatible social page using flexbox.

Mason• 100

@mrcrist2526

Desktop design screenshot for the Social proof section coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


I learned @media at-rule here which was an extreme headache. I up unhappy with the how the site looks at different widths above the min-height: 750px limit aside from the unadjusted landing desktop view. When I open the devtools in google however, I do not know why the content does not fit the screen.

I also don't know how to keep all of my containers in their original position when I zoom out.

Help!

Community feedback

Vanza Setia• 27,855

@vanzasetia

Posted

👋Hi Mason!

Like Manikandan has said, on mobile everything is overflowing. Try to fix this layout issue.

I have some feedback on this solution:

  • You should wrap all your page content, except the attribution with main tag.
  • For the attribution, you can swap the div with footer tag.
  • Only have one h1 for every page. It's a good practice and good for accessibility. Also the Rated 5 stars..., should not be headings.
  • Avoid inline styling! It can create a lot of issues, especially on bigger project.
  • Heading order is extremely important. You need to use h1, h2, h3, and so on. Remember don't use heading for making the text bold and smaller.
  • You might want to use strong or em tag instead of heading tags.
  • For the comment, I recommend to use blockquote to make it more semantic.
  • Always set all elements to box-sizing: border-box to prevent unexpected things when you're adding padding.
  • Use rem or sometimes em instead of px. Using px will not allow the users to control the size of your page based on their needs.

That's it! Hopefully this is helpful!

Marked as helpful

0

Mason• 100

@mrcrist2526

Posted

@vanzasetia This was very helpful. Thanks a ton!

0
Manikandan• 5

@vasimani

Posted

Mobile view is over lapping

There lots of gab between top section and bottom section

Otherwise is good

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord