Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Advice generator app - Solution

Nathassia 30

@nathassiaaw

Desktop design screenshot for the Advice generator app coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
  • API
2junior
View challenge

Design comparison


SolutionDesign

Community feedback

Ahmed Bayoumi 6,800

@Bayoumi-dev

Posted

Hey Nathassia, Congratulations on completing this challenge... You have some accessibility issues you need to fix.

  • Document should have one main landmark, Contain the component in <main>.
<main>
   <div class="container">
      //...
   </div>
</main>
  • An img element must have an alt attribute, to provide alternative information for an image if a user for some reason cannot view it.
  • This <div class="dice"></div> Should be button... Buttons are used for actions.

I hope this is useful to you... Keep coding👍

Marked as helpful

0

Nathassia 30

@nathassiaaw

Posted

@Bayoumi-dev Thanks for your review! I will improve the code soon :)

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord