Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Advice generator app solution

#fetch

@daishek

Desktop design screenshot for the Advice generator app coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
  • API
2junior
View challenge

Design comparison


SolutionDesign

Community feedback

Danilo Blas 6,280

@Sdann26

Posted

Your project is fine, it is responsive and has a good functionality but I recommend you to fix the frontend mentor bug report.

In your case you have two div inside your body, and you should put it in landmark tags or all inside the <main> tag. The reason is that the body is usually composed of different landmark tags and these in others. Among the landmark tags we have: <main>, <footer>, <nav>, <header>, etc.

So to eliminate the errors at once make these changes:

  • Change <div class="container"> to <main class="container">.
  • Change <div class="attribution"> to <footer class="attribution">.

With this update you should no longer have any problems. So don't forget to generate a new report to get 0 errors.

Hope my comments are helpful :D!

Marked as helpful

1

@daishek

Posted

@Sdann26 Thank you, I'll fix it.

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord