Ahmed Bayoumi• 6,800
@Bayoumi-dev
Posted
Hey Stefano, It looks good!... You have some accessibility issues you need to fix.
Document should have one main landmark, Contain the component in<main>.
<main>
<div class="main-container">
//...
</div>
</main>
Page should contain a level-one heading, You should always have oneh1per page of the document.Buttons must have the discernible text, Set the attributearia-labelto describe this button.
<button type="button" class="dice" aria-label="Advice generator"></button>
I hope this is useful to you... Keep coding👍
Marked as helpful
0
Stefano Mainetti• 50
@stefanomainetti
Posted
@Bayoumi-dev Hi Ahmed, many thanks for your comments. I really appreciated your attention. Accessibility is actually a new matter to me and I've not had the change to dive into it yet. I will for sure do my homeworks now and implement the principles in the following challenges.
I've fixed the code. The only doubt was on where to put the h1. I've decided to apply to the ADVICE# and mark as paragraph the quoted text trying to make it as "semantic" as possibile. Hope this makes sense.
0
