Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Base Apparel landing page using Grid, Flexbox, & SCSS

@klettsome

Desktop design screenshot for the Base Apparel coming soon page coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hi,

I'm Kallom and I have been learning HTML and CSS for about a month now. Once I start learning JavaScript, I will come back and add the validation. I would any feedback that you can give on improving my code especially on how to keep it DRY.

Community feedback

P
Matt Studdert 13,611

@mattstuddert

Posted

Hey Kallom, congrats on submitting your first solution. It looks great! You've obviously learned a lot in a month! 👍

As far as keeping your code DRY goes, I'd recommend a couple of things based on your CSS:

  • Avoid using IDs for styling purposes. They can't be reused on the page and so you find yourself repeating selectors when you could use a class instead.
  • I'd recommend having a go at using min-width media queries instead of max-width media queries in a project. Using them can often reduce the amount of code you write and also has the added benefit of loading in fewer styles for mobile users.

I hope these tips help. Keep up the great work!

0

@klettsome

Posted

@mattstuddert

Thank you Matt! That definitely helps. I will use that in my next challenge and see how that goes!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord