Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Bookmark landing page, using html5, sass and javascript

@bambamayo

Desktop design screenshot for the Bookmark landing page coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
3intermediate
View challenge

Design comparison


SolutionDesign

Solution retrospective


  1. I would love feedack on my choice of javascript selectors and function logic. 2)Also if my sass code and bem structure is correct

Community feedback

P
Matt Studdert 13,611

@mattstuddert

Posted

Hey Ayobami, great work on this challenge! Your Sass and BEM structure looks great. One thing you could do on the BEM side is breaking to a new component in certain instances, which would help reduce the names. For example, .header__nav__list could become .nav.

Also, your JS looks good. I would be aware that your mobile nav open/close is currently inaccessible to people using screen readers though, as you've got a click event on an SVG, which isn't typically an interactive element. I would recommend wrapping the SVG in a button and adding the click event to that.

Keep up the great work! 👍

1

@bambamayo

Posted

@mattstuddert Thanks a lot for this feedback, i will work on the things you mentioned

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord