@mattstuddert
Posted
Hey Ayobami, great work on this challenge! Your Sass and BEM structure looks great. One thing you could do on the BEM side is breaking to a new component in certain instances, which would help reduce the names. For example, .header__nav__list
could become .nav
.
Also, your JS looks good. I would be aware that your mobile nav open/close is currently inaccessible to people using screen readers though, as you've got a click event on an SVG, which isn't typically an interactive element. I would recommend wrapping the SVG in a button
and adding the click event to that.
Keep up the great work! 👍
@bambamayo
Posted
@mattstuddert Thanks a lot for this feedback, i will work on the things you mentioned