Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Bootstrap; css only

sm-bashaβ€’ 120

@sm-basha

Desktop design screenshot for the Four card feature section coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

P
Matt Studdertβ€’ 13,611

@mattstuddert

Posted

Nice work on this solution and congratulations on submitting your first solution! I've got a couple of tips to give after taking a look at your code:

  • You've got two h1 elements on the page at the moment, whereas I'd recommend only ever one. This is for accessibility reasons, as screen reader software typically uses the h1 as the page title.
  • The h6 you've got would work best as a paragraph instead, as you wouldn't describe that content as a heading.
  • Your card headings are all h4, which is a big jump from the h1. I'd recommend never skipping heading levels, so h2 elements would make sense in this context.
  • Also, you don't need to use the b tag inside of headings, as they're given font-weight: bold; by default.

I hope these tips help. Keep up the great work! πŸ™‚

1

sm-bashaβ€’ 120

@sm-basha

Posted

@mattstuddert Thank you for the valuable feedback.

0
P
Matt Studdertβ€’ 13,611

@mattstuddert

Posted

@sm-basha you’re welcome!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord