P
Matt Studdertβ’ 13,611
@mattstuddert
Posted
Nice work on this solution and congratulations on submitting your first solution! I've got a couple of tips to give after taking a look at your code:
- You've got two
h1
elements on the page at the moment, whereas I'd recommend only ever one. This is for accessibility reasons, as screen reader software typically uses theh1
as the page title. - The
h6
you've got would work best as a paragraph instead, as you wouldn't describe that content as a heading. - Your card headings are all
h4
, which is a big jump from theh1
. I'd recommend never skipping heading levels, soh2
elements would make sense in this context. - Also, you don't need to use the
b
tag inside of headings, as they're givenfont-weight: bold;
by default.
I hope these tips help. Keep up the great work! π
1
sm-bashaβ’ 120
@sm-basha
Posted
@mattstuddert Thank you for the valuable feedback.
0
P
Matt Studdertβ’ 13,611
@mattstuddert
Posted
@sm-basha youβre welcome!
0