Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

challenge #1 qr

@YaseenAbdualhameed

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

Ahmed Bayoumi 6,800

@Bayoumi-dev

Posted

Hey Yaseen, Congratulations on completing this challenge... You have some accessibility issues you need to fix.

  • Document should have one main landmark, Contain the component in <main>.
<main>
   <div class="ppp">
      //...
   </div>
</main>
  • Page should contain a level-one heading, Change <div>Improve your front-end skills by building projects</div> to <h1>Improve your front-end skills by building projects</h1>, You should always have one h1 per page of the document.

This element <h1> represents the section headings.

  • I suggest you contain the attribution in <footer>.
<footer>
   <div class="attribution">
      //...
   </div>
</footer>
  • This should be contained in paragraph tag <p> <div>Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</div>, to add more semantics to your project.
<p>Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</p>
  • An img element must have an alt attribute, to provide alternative information for an image if a user for some reason cannot view it. <img src="images/image-qr-code.png" alt="qr-code">

I hope this is helpful to you... Keep coding👍

Marked as helpful

1

@YaseenAbdualhameed

Posted

@Bayoumi-dev hi Ahmed , thank you for your suggestions i'm edited all of them 🌹🌹

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord