Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Clipboard-Landing-Page

maxcramer 30

@maxcramer

Desktop design screenshot for the Clipboard landing page coding challenge

This is a solution for...

  • HTML
  • CSS
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


How is the quality of the Markup? What would you of coded and what method would you have used?

Community feedback

@gabysantosw

Posted

You did a great job! The site looks good and is properly responsive. Some tips I can give:

About the markup: I would highly advice to use the button tag instead of divs. It's more semantic and needed for accessibility. I noticed the footers links are not actually anchor tags/links, the styling is great but as a practice for the real world: these should be clickable (a tag) and wrapped in a nav tag to convey they are a navigation. Same with the social images. You can also check the report frontend mentor gives you with many tips.

Other than that, to improve the organization of the css for other projects, you can check out BEM: http://getbem.com/introduction/, allows for more clear naming conventions and gives other recommendations.

Keep it up 🎉

1
maxcramer 30

@maxcramer

Posted

Hi Gabysantosw,

Thanks for that! The reason I used divs here rather than anchors or buttons was because with this single page, I was trying to stop default behaviour of sending to a link that doesn't exist. Is there a way to do this with buttons and a tags? Thanks again for the feedback!! so appreciate it

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord