@ApplePieGiraffe
Posted
Hi, Abhik! 👋
Great job on another challenge! 👍 Your solution looks good, responds well, and those animations look very nice! 😃 Kudos for trying out Sass and BEM! 👏
Your BEM looks good! One or two very small things I might suggest are perhaps to use card--one
and card--two
rather than card one
and card two
(since one
and two
are adjectives and therefore more like modifiers) to make recognizing what those classes do in your CSS easier. Also, you may want to use dashes rather than single underscores to separate words (as in card__slider-top
rather than card__slider_top
) just to make the distinction between elements and regular words easier. 😉
Of course, keep coding (and happy coding, too)! 😁
@abhik-b
Posted
Thanks @ApplePieGiraffe for the valuable feedback , I'll implement the changes. Glad you liked my animations 😇
Happy coding 🚀