Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Fifth challenge ! The last at the "newbie" level for me

@FloPereira75

Desktop design screenshot for the Ping single column coming soon page coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


This is the last newbie level challenge that I am doing, I will now level up and tackle more complicated challenges! Do not hesitate to give me your opinion, or if you have any questions or anything!

And good code to you all!

Community feedback

P
ApplePieGiraffe 30,545

@ApplePieGiraffe

Posted

Hey, Florian Pereira! 👋

Your solution looks great and responds well! 👏

I'm happy to hear this is your last "Newbie" challenge! Look forward to seeing more, as well! 😆

Simply follow brasspetal's helpful suggestions to clear up your solution report and you should be good to go! 👍

Keep coding (and happy coding, too)! 😁

1

@FloPereira75

Posted

@ApplePieGiraffe Thank you ! I'll take care of it right away. And we're off to a new week of code!

0
Anna Leigh 5,135

@brasspetals

Posted

Hi, Florian!

To clear up the errors in your report:

  • add an aria-label to your email input
  • add titles to your svgs. Ex: <svg <title>facbook</title> ...rest of svg file...

Overall your solution looks great and responds pretty well, but I did notice some slight issues. While using percentages for responsiveness is great, I suggest also pairing it with max-width and/or clamp(). The margins get oddly stretched on tablet views between the header, text, and input, and the padding around the email and button gets very big on larger screens (ex: 1920px). Other than that your solution really is good, and I'm looking forward to seeing your junior challenges! Happy coding!

1

@FloPereira75

Posted

@brasspetals Thanks for the time taken and the feedback! Very cool, I told myself that it was not normal that I have such big margins haha. I have a small screen (less than 1400px) so I never really know if I have set the right margins / padding! So I will take care of the mods that you recommend me! thanks again

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord