@AgataLiberska
Posted
Hi @MojtabaMosavi! Well done on this challenge, it looks great! The only thing I see is that it would be good if the container was centered on the page, on my screen it's more towards the left. It's an easy fix, try using dev tools to find it, and let me know if you're struggling - I'll help you out :)
Oh and consider using rem or em as your units instead of px - it makes the design more accessible (the default font in most browsers is 16px, but users can change that, and the design should scale accordingly - but if you use pixels, it won't)
Hope this helps! :)
@MojtabaMosavi
Posted
Hi @AgataLiberska, thanks alot for the comments, I put margin: center; on the contianer to centre it but I guess there is some wrong styling that caused it. Great comment about on the units. Thank you :).
@AgataLiberska
Posted
@MojtabaMosavi margin: auto
is a good way to center your container, but I was talking about your <body>
styles. You've set the max-width there to 1440px, so it won't stretch past that size, it will just keep adding margin on one side - that's what's causing the container to be more on the left side on screens wider than 1440px. You can see the computed padding and margin in dev tools on your browser.
Try setting max-width on your container instead (the value may be different than 1440px) :)