@pikapikamart
Posted
Hey, awesome work on this one. Desktop layout looks really nice, though when resizing the screen, the layout is being hidden thus creating horizontal scroll. It would be great to make the site more responsive. Mobile state looks great but your breakpoint of 375px is too little, other phones have higher width than that so they won't get the mobile layout, toning it up would be really great and also, using mobile first approach will be really great since it will help you addressed issues like this.
Ken already gave great feedback on this one, just going to add some other suggestions as well:
- The text
Reliable, efficient delivery Powered by Technology
should be using a singleh1
on this one, since that is just a single phrase with the second part on the next row. Useh1
to wrap both and usemax-width
on it so that the text will wrap like on the design, adjust it until you get the desired look. - When using a heading tag, make sure you are not skipping a level. If you use
h4
then make sure thath1, h2, h3
are all present. Changing those other heading tags into usingh2
would be great. - Those 4 icons being are only decorative. Decorative images should be hidden for screen-reader at all times by using
alt=""
andaria-hidden="true"
to theimg
tag or onlyaria-hidden="true"
if the image is usingsvg
. - Only use descriptive
alt
on images that are meaningful and adds content to the site otherwise hide the image for screen-reader users. - Lastly, making the site as responsive as you can so that you can avoid the issue when resizing the screen.
Aside from those, great job again on this one.
Marked as helpful
@omarfarids
Posted
@pikamart hey, thank you for this great feedback. great points you have mentioned. and I would ask you about some of them : -making horizontal scroll by (overflow-x:scroll) ? -when using (alt=) I write discription for the Image not statement that it can't display? -what (aria-hidden="true") does ? -when I get frontend mentor feed back ,it gives me something about accessibility issue (<html lang="en">) and don't really know how to fix this. again thank you for your feedback. I'm new at this field and it really helps.
@pikapikamart
Posted
@omarfarids Hey!
- For the horizontal scroll, like what I said, the layout is not responsive enough so if you go for example at like size 600px, you will see that the layout is being hidden and the horizontal scrollbar is at the bottom which means layout is not responding well.
- Yes, text will not be visible when using
alt
but, only use descriptive text or descriptivealt
when you think that an image adds content to your site. If the image is just purely decoration, hide them using:
<img alt="" aria-hidden="true" />
aria-hidden="true"
makes an element not be caught by screen-reader. You typically do this when there is a content like a decorative image on the site that doesn't really add any meaning, you use the attribute so that theimg
will be hidden.- For the last issue, as you may have read it, page should have level one heading tag or an
h1
. Like what I suggested at my previous feedback, use theh1
to wrap the two bold text on the site. This way, your site will have anh1
.
Marked as helpful
@omarfarids
Posted
@pikamart thanks for all these details and I will be grateful if I always get your feedback on my work ..