@brasspetals
Posted
Hi, E1DR1 and congrats on completing this challenge! 🎉 This one was a much harder than I thought it would be as well, but I think it's a great learning experience. You did a good job, but here's a few suggestions to make it even better.
First, to clear up some of the errors in your report:
- add an aria-label to you email input
- add
<title>tags and a value (ex:<title>facebook</title>)to your social icon svgs - remove your empty “final-description” section
Some other suggestions:
- Adding a max-width with a set value (like px) to your location__img will prevent it from getting larger than the others
- Changing the social icon hover to blue or cyan. The white makes the icon “disappear” when hovering.
- Between 600px-1024px your .get-started div positioning goes a bit goofy, which you might want to look into.
- Adding a max-width to your review cards so they don’t get too stretched out on medium sizes. You can then add
justify-content: centerto your .reviews grid to keep everything nice and centered. You can also do this to your info section, adding a max-width to .info and the justify-content to .icons__info. - Changing .about-us to
flex-direction: columnand adding a bit of margin between the link columns for the mobile layout.
@AdriCappelletti
Posted
@brasspetals Awesome feedback! thank you, i will check out and correct those things. I started with html and css only 2 months ago so i have a loooot of mistakes. Happy coding :)
@brasspetals
Posted
@E1DR1 I think you're doing great! Making "mistakes" is a big part of learning, and I not-so-secretly wish my solution gets torn apart each time I submit one. The feedback from these challenges (as well as the challenges themselves) has really helped me improve just in the month or so I've been doing them. Trust me, my solution for this challenge may look "correct", but the code is...not ideal. I had a major screw up, which still isn't entirely "fixed." 🤦♀️ But again, I learned so much from it - and certainly won't do it again! 😂
