Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

HTML and CSS solution

vNawar 40

@vNawar

Desktop design screenshot for the Profile card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


It would be a huge help if anyone can point out to me any kind of bad practices or wrong ways I followed to complete this challenge.

Community feedback

Fraser Watt 1,790

@fraserwat

Posted

Hey, congrats on your first challenge! 🎉

There's a few things I think could make this a little more responsive.

  • instead of having the two background images in div's I reckon you'll have an easier time with it if you have them as background-image attributes of the body element, and do the positioning in vh and vw measures instead of percentages. You'll then be able to get rid of the @media queries there.

  • You'll want to do max-widths to stop things getting too wide, but generally you won't want to be dictating widths and heights, so its more flexible on different screen sizes. You should be able to sort most of this stuff out with margin and padding. When your total screen width approaches the width of the element, it should shrink (leaving a bit of a gap with margin).

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord