Greetings Mukul. So far so good on the project.
- the site is looking good on mobile up to the 375px mark and desktop but for medium devices there is still work to be done.
- Consider semantic html elements where possible to improve the accessibility of the site. For example use an ordered list for the navigation list items , something like
<ul>
<li><a href="#">About</a></li>
<li><a href="#">Services</a></li>
<li><a href="#">Projects</a></li>
<li><a href="#">Contact</a></li>
</ul>
- look into responsive images , eg the picture element , at the moment you are having 2 separate img elements(one for mobile and another for desktop) and then hiding them using a css class - which is not the recommended way of displaying images. See the following article for some explanation responsive images
Happy coding
Marked as helpful
1
Mukul Jain• 70
@mukul-1985
Posted
thanks @ChamuMutezva for the review.
- I created site only for two form factors (desktop and mobile) as per the specification given in the design. But in future I will take care to include medium devices too.
- thanks for the review, I will consider semantic html elements to improve accessibility.
- thanks for the article on responsive images, its really informative.
0
