@samuelpalaciosdev
Posted
Hi, Chris👋
Great job on this challenge. Your solution looks good and it scales pretty well👍
I only suggest some things 😉:
-
Changing the button to an <a> (anchor link). If this would be an actual webpage, those buttons should redirect somewhere.
-
As Karim said, instead of using
overflow:hidden
you should useoverflow-x:hidden
. Because, if you left as it is right now, I can't scroll on mobile viewport.
I hope this would help you, have a nice day, keep coding!
@Chriseden83
Posted
@samuelpalaciosdev Hi Samuel,
Thank you so much, I really appreciate it. You make good points on both, after thinking about them they do make sense. I wasn’t 100% happy with how this challenge panned out but I’ve learnt a lot.
Looking forward to getting stuck into other challenges.
@samuelpalaciosdev
Posted
I'm glad I helped you, remember, learning to code is a non-linear process and forcing a strictly linear structure on it will slow your learning process. It is analogous to learning a language.