Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Loopstudios landing page BEM SASS

E_X_E• 295

@Alex-AR-LR

Desktop design screenshot for the Loopstudios landing page coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


I would appreciate any help to keep improving

Community feedback

Ahmed Faisal• 5,095

@afrussel

Posted

Looking nice in mobile view.

Marked as helpful

1
P
tediko• 6,500

@tediko

Posted

Hello, E_X_E! 👋

Good effort on this challenge! 🎉 Everything works good and responds well. Take a look at:

  • Add :focus pseudo class to interactive elements like anchors, buttons etc. Use outline property to make your website more accessible to keyboard users. Focusable elements like anchor, buttons or inputs they have applied default :focus pseudo class with outline property. These default styles are subtle and hardly visible tho. Furthermore every browser has a slightly different default style for the outline, so you probably want to change the default style. Read more about why we should change focus styles.
  • Change the alt attribute for the .card__img, as it doesn't add any extra context for screen reader users. Since your image is decorative your alt text should be provided empty (alt="") so that they can be ignored by assistive technologies.
  • I'd also change the alt attribute for header__link logo. "logo" is not descriptive, and since you wrap your image with anchor tag and it direct to home page maybe change alternative text to "Loopstudios - home page".

Good luck with that, have fun coding! 💪

Marked as helpful

0

E_X_E• 295

@Alex-AR-LR

Posted

@tediko Thank you very much for taking the time to review my code !! I see that I have a lot to learn about accessibility! Thank you very much for the advice!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord