Amon• 2,560
@A-amon
Posted
Hello! Great work~ The responsiveness looks good too!
I have a few suggestions:
-
Everything (font-size and image) looks a little oversized. Maybe, shrink them? 😂
-
Putting script element among the code...It's my first time seeing this. 🤔 Not sure if it's right or wrong but, you can try putting it at the end of body tag, right before closing.
-
I believe your input element should have a label element for it or an aria-label attribute. Check this out: https://stackoverflow.com/questions/9157867/placeholder-vs-label-for-input-in-html5
-
Instead of div for each social media icon, they should have been a tags.
-
Instead of setting styles directly inside JS, add/remove or toggle class instead.
I learnt about using title tags inside svg. Awesome! 😀
0
