@mattstuddert
Posted
Hey Samir, nice work on this challenge! You've done an excellent job, and your solution looks very similar to the design! Here are some thoughts after taking a look at your code:
- You're only using
h2
headings in this project. I'd say the top one would be ah1
for this challenge. You could then usespan
elements inside to style the text differently. - You're using
br
tags after the paragraphs in the cards. You don't need to do this because paragraph elements display block by default. - For the images inside the cards, I'd leave the
alt
values empty. This means screen reader software would skip those images. In this instance, that's a good thing, as you're repeating the same content as each card heading. - Your CSS looks good. I'd recommend revising your breakpoint, though. At the moment, you're using
min-width: 376px
. While it's great that you're usingmin-width
, try looking at your project at377px
or any other mobile screen size up to the tablet ranges. You'll see the content looks very squashed.
I hope those tips help! Keep up the great work 👍
@samirhembrom
Posted
@mattstuddert Thank you for the feedback, I have to brushup on breakpoint, and I need to keep a note on when to use which HTML elements. I used br for giving a slight gap between the image and paragraph.