@mattstuddert
Posted
Nice work on this challenge Amit and congrats on submitting your first solution! 🙂
I like the added detail of the content animation. How did you get on with this challenge? Did you learn anything new while building the project?
Keep up the great work!
@mattstuddert
Posted
@amit-c1308 nice! Everything looks great with your code. The one small suggestion I'd have is to not have 2 h1
elements. You should only ever have a single h1
for accessibility reasons. So I'd recommend changing heading to a single h1
and then you could use span
elements to separate the two lines.
Hope that helps!
@amit-c1308
Posted
@mattstuddert heyy thanks for the feedback !
yeah the animation itself was new in a way for me, as i had never worked with @keyframes and animation property before, so i experimented with it a bit here based on something similar i had seen a while back. Apart from that i always find the whole flex-box implementation a bit challenging so i used that here to make the cards as per the requirements.
Any suggestions for improvements is appreciated.