@BikeInMan
Posted
I personally think you did it great job, even though the validator may complain of not having a h1 or h2.
Marked as helpful
@julian-hartl
Posted
@BikeInMan Thank you very much :)
Looking to hire developers?
Hello everybody, I known that this challenge is pretty easy and straightforward but I'd still be happy about some feedback. I would really like to know, if I did an ok-job at structuring my html or if overcomplicated things. Maybe I could add some classes to remove duplicated css or remove some divs from my markup. Thanks in advance :)
@BikeInMan
Posted
I personally think you did it great job, even though the validator may complain of not having a h1 or h2.
Marked as helpful
@julian-hartl
Posted
@BikeInMan Thank you very much :)
@ApplePieGiraffe
Posted
Hi, Julian Hartl! 👋
Nice job on this challenge! 👏 Your solution looks great! 😀
A few things I'd like to suggest are,
alt
text for the images that are the icons in the card component to an empty string. That's because the purpose of those images are mostly decorative and need not be announced by assistive technology like screen readers. Leaving the alt text to those images empty will ensure that the images are ignored by screen readers so that they can focus on the other, more important content on the page.Hope you find those couple of tips helpful. 🙂
Keep coding (and happy coding, too)! 😁
Marked as helpful
@julian-hartl
Posted
@ApplePieGiraffe Thank you very much! It is so great that resources like these exist. I will definitely look into the BEM methodology!
@ApplePieGiraffe
Posted
@JuHar-dev
Glad to help! 😀
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord