Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Music Card

Jontim 145

@Jon-tim

Desktop design screenshot for the Order summary component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

Jason Heys 175

@heyitsgany

Posted

Nicely done! Your solution looks good, although looking at the live version on GitHub pages there are a few things that could be changed to improve it.

Firstly, changing the 'container' div to a main element would solve the accessibility issue that your solution is getting.

Secondly, your background image is mispositioned and doesn't repeat. So, look at making it repeat on the x-axis and let it position itself.

Otherwise nice work!

0

Jontim 145

@Jon-tim

Posted

@heyitsgany Thank you for your feedback. I think there is a problem "update solution" button, it doesn't update at all, despite the fact that i have updated he code.

0
Jason Heys 175

@heyitsgany

Posted

@Jon-tim I can see you've got two branches on your github for this project. You'll need to push your changes to the main branch for anything to update on the live version. Also, looking at your recent commit; you wanted to change <div class="container"> to <main class="container>. Sorry if I wasn't clear.

Marked as helpful

1
Jontim 145

@Jon-tim

Posted

@heyitsgany

tried again!

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord