P
ApplePieGiraffeβ’ 30,545
@ApplePieGiraffe
Posted
Hey there, Olorundami Joseph! π
Congratulations on completing your first Frontend Mentor challenge! π Great job on this one! π
A couple of things I'd like to suggest are,
- Avoiding using
px
for setting the value offont-size
in your styles. Instead, use a responsive unit such asem
orrem
so that users will be able to change the size of the text in your site by changing the default font-size of their browser. It might also be worth setting the values for other properties such asmargin
orpadding
in those units so that your entire site will scale with the user's chosen default font-size. If you'd like to learn more about those units in CSS and how all of this works, check out this helpful video on the topic. - Perhaps adding some more descriptive
alt
text to the images in this card component. Thatβs becausealt
text is read by screen readers to describe images to users, so itβs important to writealt
text that makes sense and will give users a good sense of the content and purpose of an image. If an image isn't important/necessary for the content of the page and could be ignored by screen readers, then just leave thealt
text blank instead. π
Hope you find these suggestions helpful. π
Keep coding (and happy coding, too)! π
Marked as helpful
3
Joseph Folaβ’ 590
@Fola-Joe
Posted
@ApplePieGiraffe Thanks so much. Very much appreciated!
1
P
ApplePieGiraffeβ’ 30,545
@ApplePieGiraffe
Posted
@Fola-Joe
Happy to help! π
1