@vanzasetia
Posted
š Hi Stephen Nicholls!
š Congratulations on finishing this challenge! You can compare your solution with mine. If you want to know more about how I did the overlay, you can read the README
.
Grace has given some incredible feedback. Here is some feedback from me:
- You can wrap
<a class="title">Equilibrium #3429</a>
withh1
. Keep in mind, that every page should have oneh1
. <h2 class="creator-text">Creation of <a class="creator-link"href="#">Jules Wyvern</a></span></h2>
There's no need to make this as a heading. Heading tag is similar to the title on a document file. I would recommend swapping theh2
withp
.- You can wrap the
ETH
withabbr
tag, since ETH is an abbreviation for Ethereum. - For the line, you can use
border
instead of emptydiv
. - Don't change the
html
or root font size. You should set thefont-size
on the element usingrem
unit. Usingpx
won't allow the user to control the font size based on their needs. - Create a custom
:focus-visible
styling to any interactive elements (button
, links,input
,textarea
). This will make the users can navigate this website using keyboard (Tab
) easily.
That's it! Hopefully, this is helpful!
Marked as helpful