Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

NFTchallenge with CSS custom properties and Flexbox

@Christ-Kevin

Desktop design screenshot for the NFT preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

Byronβ€’ 2,180

@byronbyron

Posted

Not bad @Christ-Kevin

I'd suggest having a look at the accessibility/html issues flagged by the FE mentor report πŸ‘

  • All page content should be contained by landmarks
  • Bad value auto for attribute height on element img: Expected a digit but saw auto instead.
  • Section lacks heading. Consider using h2-h6 elements to add identifying headings to all sections.
  • etc.

Other than that looks good! The massive height is a new one as well πŸ˜†

0

@Christ-Kevin

Posted

@byronbyron, thankyou for the feedback. But I have a question. What do you mean with "(...) The massive height is a new one as well " ? do you mean that the height of my container is massive ? or do you mean something else. If I made something wrong with this "massive height", could you explain me how i could avoid it ? Do you have a kind of solution ?

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord