Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Only HTML CSS Flexbox & JavaScript!

Botch 125

@eZapataCode

Desktop design screenshot for the FAQ accordion card coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hi everyone! this is my solution for this challenge, i'm new on this bussines and i'm very motivated, i know my code and positioning skills must be quite bad, so i would love to be told where i can improve and start working on it! thanks so much in advance, have a nice day!

Community feedback

P
ApplePieGiraffe 30,545

@ApplePieGiraffe

Posted

Hey, Botch! 👋

Good job! 👍

And congratulations upon completing your first Frontend Mentor challenge! 🎉

In addition to felipeog's feedback, I suggest,

  • Adding cursor: pointer to the titles of the FAQs.
  • Adding a max-width to the accordion component so that it doesn't grow too wide on extra-large screens.

Keep coding (and happy coding, too)! 😁

2

Botch 125

@eZapataCode

Posted

@ApplePieGiraffe hey! thanks, you will hear more about me in the future here!

-Adding cursor: pointer to the titles of the FAQs. pretty important detail! i forgot it.

-Adding a max-width to the accordion component so that it doesn't grow too wide on extra-large screens. oh, its a better idea, it would save me a lot of work with media queries, thanks

2
Felipe OG 730

@felipeog

Posted

This comment was deleted

2

Botch 125

@eZapataCode

Posted

Hey @felipeog! Thanks for taking the time to check my code!

-I believe that using the background pattern as .illustration-div's background-image would be a better approach Ohh, its true, by doing that would have saved me a lot of time! -Fixed

-When an accordion is open, the arrow should be pointing up and the question should be bold Lol, i forgot to add that functionality in the .js file, i even selected the icons with the querySelectorAll, i always forgot some detail haha, thanks! -Fixed

-The FAQ title should be bold i know that but i don't know how to do it :(, i tried with font-weight: bold and font-weight: 900, but it didn't work for some reason.

-The code indentation is inconsistent, you could use a formatter plugin Ohh, i didn't know that existed, definitely that will help me a lot!

thanks so much again you helped me a lot to keep improving!

1
Felipe OG 730

@felipeog

Posted

Hey, @eZapataCode!

Good job on the fixes, it is looking good.

About the font weight, you can define the weights you want on the Google Fonts import: Kumbh+Sans:wght@300;400;700

Happy coding!

1
Botch 125

@eZapataCode

Posted

@felipeog Aahh, so that's how it's done, thanks! i've already fixed it!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord