Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Order summary component // HTML & CSS

#itcss#styled-components
Kenan 20

@kenankevric

Desktop design screenshot for the Order summary component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


I am unsure if I should use colors in CSS like this or set up variables.

Community feedback

Nneoma Njoku 1,210

@SatellitePeace

Posted

HELLO @kenankevric nice work

Setting up variables are usually important when you have a large codebase with many different styles and colours so that if you want to change a style you only have to do it in one place

But for a projects like this, which which will be 100 - 150 lines of css it is easy to navigate through and make changes

So it is not very important to use variables for projects like this

However, if you choose to use variables that is completely fine

Marked as helpful

0

Kenan 20

@kenankevric

Posted

@SatellitePeace Thank you for the clarification.

1
Adriano 33,940

@AdrianoEscarabote

Posted

Hi ata58011, how are you?

I really liked the result of your project, but I have some tips that I think you will like:

1- Every pages needs a <h1> to show which is the most important heading. So replace the <h2> with <h1> and follow the sequence h1-h5

I noticed that the content is not centered to fix this we can do the following:

body {
    display: flex;
    align-items: center;
    justify-content: center;
    flex-direction: column;
    min-height: 100vh;
}

Prefer to use rem over px to have your page working better across browsers and resizing the elements properly

The rest is great!!

Hope it helps...👍

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord