Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

ping single column coming soon page

@fadzrinmadu

Desktop design screenshot for the Ping single column coming soon page coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


please review my code and let me know what i need to improve, thanks in advance

Community feedback

P
Matt Studdert 13,611

@mattstuddert

Posted

Nice work Muhammad! I've just got a couple of small recommendations, so nothing major:

  • I would lowercase the "Ping" logo in your HTML so that screen reader software doesn't read it out letter-by-letter. You can then use text-transform: uppercase; in your HTML to visually uppercase it.
  • You've gone straight in with a h3 heading, but you've not got any h1 or h2 elements. I would always recommend starting with a h1 as your main page title.

I hope this helps. Keep up the great work! 👍

Marked as helpful

1

@fadzrinmadu

Posted

@mattstuddert very helpful thanks for the feedback. one question how to solve the problem in my report? I have been looking for it but have not found the right solution

0
P
Matt Studdert 13,611

@mattstuddert

Posted

@fadzrinmadu you need to either add some text inside the anchor tag, which you can then visually hide so that it's only accessible to screen reader users. Or you can add an aria-label attribute to the anchor tags to provide the link text.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord