@mattstuddert
Posted
Hey Adler, nice work! As you mentioned, the component in the design has its width constrained, whereas your solution stretches. I'd recommend having a go at refining that to get it looking as close to the design as possible.
Here are some other pointers after taking a look at your code:
- You've got
h1
andh3
headings, but noh2
. It's recommended to avoid skipping heading levels as this can lead to accessibility issues with the content hierarchy. - You're using IDs for styling, which I'd recommend against. They're overly specific and they can't be reused on the page. Instead, stick to class, attribute, pseudo, and type selectors. It will help keep your code more maintainable, especially as you start building larger projects.
I hope that helps. Keep up the great work!