Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

product

@Vishallab

Desktop design screenshot for the Product preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


it cannot be live on my github page ,i dont know why if you download my file and opwn in vscode or any editor then it wil same looks like your

Community feedback

@MelvinAguilar

Posted

Hi @Vishallab, good job for completing this challenge! 👋

Here are some suggestions to improve your code:

Rename the vishal.html file to index.html, also rename vishal.css to style.css .

And update the link href to:

<link rel="stylesheet" href="./style.css">

When you visit a webpage like https://vishallab.github.io/product/, it automatically looks for a file named index.html to show the content, it's just a standard, It is configurable but for now it is better to follow the standard.

Now your solution is on https://vishallab.github.io/product/vishal.html, but change the name of the file so that just by entering https://vishallab.github.io/product/ it shows you everything correctly.

The problem is not GitHub nor the way to upload files, it is the file name

I hope those tips will help you.

Good Job !

Marked as helpful

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord