Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Product preview card component - html - sass

@ROCBrilhante

Desktop design screenshot for the Product preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Any feedback to improve my code would be appreciated :-)

Community feedback

P
ApplePieGiraffe 30,545

@ApplePieGiraffe

Posted

Hey, RBrilhante! 👋

Nice job on this challenge! 👏 Your solution looks great and responds nicely! 👍

One small suggestion I have is to not set the font-size of the body to a value in px. Instead, consider setting the font-size to a percentage so that users will be able to change the size of the text in your site by changing the default font-size of their browser. That way, the em and rem values that you use throughout the rest of your CSS will be based on the variable font-size set by the user. If you'd like to learn more about how all of this works, check out this helpful video on the topic.

Hope you find this helpful. 😊

Keep coding (and happy coding, too)! 😁

Marked as helpful

2

@ROCBrilhante

Posted

Hi @ApplePieGiraffe !

Thanks for the suggestion and explanation 👍 I will make this change. Very useful of course 😁

Thanks once again and happy coding to you too!

1
P
ApplePieGiraffe 30,545

@ApplePieGiraffe

Posted

@ROCBrilhante

Glad to help! 😊

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord