@VCarames
Posted
Hey @rain-riot, some suggestions to improve you code:
-
Your not using the Alt Tag effectively, This is image isn't decorative, it serves purpose. The Alt Tag should not be blank it needs to have some content in it. You want to describe what the image is; they need to be readable. Assume you’re describing the image/icon to someone.
-
The old price isnt being announce properly to screenreaders. You want to wrap it in a Del Element and include a sr-only text explaining that this is the old price.
-
Your CSS Resets are extremely bare, you want to add more to them. Here are few CSS Resets that you can look at and use to create your own CSS Reset or just copy and paste one that already prebuilt.
https://www.joshwcomeau.com/css/custom-css-reset/
https://meyerweb.com/eric/tools/css/reset/
http://html5doctor.com/html-5-reset-stylesheet/
- To keep your CSS code organized and easier to use, I suggest implementing CSS Variables. This will come in handy when building large websites, using light/dark mode, etc…
More Info
https://developer.mozilla.org/en-US/docs/Web/CSS/Using_CSS_custom_properties
https://www.w3schools.com/css/css3_variables.asp
Happy Coding!
Marked as helpful
@rain-riot
Posted
@vcarames thanks for the feedback, really appreciate that.