Looking to hire developers?
This is my first submission. Reviews will be highly appreciated.
@fraserwat
Posted
With the background, I'd keep it static by using the background-image attribute, then working out the positioning based on that.
I'd also use the shadow-box attribute to get the design looking more like the original.
Looks great though - keep it up! 😎
@DammyShittu
Posted
Thanks, @fraserwat.
@VictorPolouchine
Posted
Hey ! You did well there 😊 Be careful with your indentation, it would really help you (and the people you collaborate with) to have a well indented code that instantly shows parent and child nodes. There are also minor typos (missing closing tag on line 27 index.html) that you may easily fix 😁 Your css could be a bit more structured also, don't hesitate to add "headlines comments" like /***** DEFAULTS /, /* NAVIGATION *******/, and group selectors (h3 can be right above h3 span) to make them easier to find ! Keep going ! 💪
@DammyShittu
Posted
Thank you so much @VictorPolouchine. I would work on all these.
@MarkoNikolajevic
Posted
Hi Adedamola! As your first time you did a really good work!
Looking at your code I've some suggestions for you
<section id="details" is missing the closing ><html lang="en">For the rest, your code is clear and understandable! Good job!
Keep on coding
@DammyShittu
Posted
Thank you for taking time out to check @MarkoNikolajevic. I'll fix the issues mentioned above right away.
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord
