Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Profile Card using CSS Grid and Flexbox

@maadcode

Desktop design screenshot for the Profile card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hi! I'd like feedback on how I could name classes in CSS, I read about BEM but don't understand it right.

Community feedback

Adarsh Pratap 5,515

@adarshcodes

Posted

Hi👋 @DavilaManuel, First of all, welcome to this amazing community, and congratulations on submitting your first solution over here.

  • For the CSS classes, If I used CSS only then I used to name the classes based on design, like hero-section, btn, para, card, attribution. But I used BEM while using SASS.
  • I saw your code and the names of the classes look fine to me, so no worries. For more on BEM go here.
  • You did nice work on this challenge, the desing is pretty similar to the original one, and responsivness is working fine on most of the devices from the developer tool.
  • Also there is no HTML or Accessibility issues aroused, which is great as this is your first challenge here. Great work👏. Keep it up. Happy Coding
3

@maadcode

Posted

Thanks @adarshcodes

I will apply the tips you gave me.

Thanks you so much :D!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord