@vanzasetia
Posted
š Hello there, Hadiza! My name is Vanza.
Good job on finishing this challenge! But I have a little feedback that might be make your css more simple. So my feedback is that instead of creating two img
tag, you can try this:
.container {
background-image:
url('../images/bg-pattern-top.svg'),
url('../images/bg-pattern-bottom.svg');
background-position: top left, bottom right;
}
As long as the container
height is 100vh
, I think this should be work.
More information about background positioning, you can try to check this š video
Last but not least, I see that you only use bg-pattern-top.svg
on both aside__img
<aside class="aside__img_1">
<img src="images/bg-pattern-top.svg" alt="">
</aside>
<aside class="aside__img_2">
<img src="images/bg-pattern-top.svg" alt="">
</aside>
That's it, overall your solution is good and hopefully this will help make it better.
@Thedeezat
Posted
@vanzasetia Thanks for the tip on the background positioning it was really helpful and a lot easier.