Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted about 2 months ago

QR Code card - first challenge

RickLearnsToCode•30
@RickLearnsToCode
A solution to the QR code component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


What are you most proud of, and what would you do differently next time?

I got it done, but got a lot of help from Copilot. As I improve I want to start doing these challenges without any AI support until I really get stuck.

What challenges did you encounter, and how did you overcome them?

I've been through several CSS tutorials but none of this seems to stick very well. I really need to get the most common properties into my head better, as well as getting much better at layouts using flex and grid.

What specific areas of your project would you like help with?

General guidance on how to remember the basics of positioning would be much appreciated. Specifically, positioning container divs on the page, and positioning child divs and elements inside them.

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Mohamed Mohamoud Elmorsy•420
    @mohamed8eo
    Posted about 2 months ago

    🛠️ CSS Improvement Suggestion

    Hi there,

    Your solution looks great overall—nice work! 🙌
    However, I noticed a couple of issues in the CSS styling that could use some refinement.

    🔹 1. Margin Issue

    You're currently using:

    margin: 25p% auto;
    

    This causes the cart to be pushed too far down the screen, and the value 25p% is not valid CSS (likely a typo). Even if corrected to 25%, relying on margin for vertical alignment can result in inconsistent positioning, especially on larger screens. Instead of using margin for vertical alignment, apply Flexbox to the body element to center the cart both vertically and horizontally:

    body {
      height: 100svh;
      display: flex;
      justify-content: center;
      align-items: center;
      flex-direction: column;
    }
    

    This approach ensures that the cart is perfectly centered within the viewport, providing a more consistent and professional layout across different screen sizes.

    Marked as helpful
  • Andrea Selmi•160
    @andreaselmi
    Posted about 2 months ago

    Hi there! Great work on your first project ☺️

    Here are a few pieces of advice to help you improve:

    📐 Use rem instead of px To make your website more accessible and responsive to user font-size preferences, it’s recommended to use rem units instead of fixed px values. This allows your layout and text to scale more naturally.

    🌁 Don't forget alt attribute Your <img> tags is missing an alt attribute. Adding descriptive alt text improves accessibility, especially for users relying on screen readers, and helps with SEO.

    💡 To improve the way you position container divs and their child elements, I suggest you take a look at https://css-tricks.com/, you can find interesting and very simple guides

    Keep going! 🚀

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub