Submitted over 2 years ago

Qr code card

Abdul Rehman•110

@abdulrehmandev

A solution to the QR code component challenge

Preview Code

Code

Couldn’t fetch repository

Please log in to post a comment

Community feedback

Melvin Aguilar 🧑🏻‍💻•61,020
@MelvinAguilar
Posted over 2 years ago
Hi @abdulrehmandev 👋, good job on completing this challenge! 🎉

I like this solution for the challenge. Here are a few suggestions I've made that you can consider in the future if you're looking to improve the solution further:
- Try to use semantic tags in your code. It should have the main tag that groups all of its elements:
```
<body>
   <main class="container">
      <article class="qr-card">
         . . .
      </article>
   </main>
<body>
```
- Instead of using pixels in font size, use relative units of measure like rem or em. The font size in absolute length units (px) does not allow users with limited vision to change the text size in some browsers. Reference.
- Add an h1 tag to your solution. The <h1> element is the main heading on a web page. There should only be one <h1> tag per page, and always avoid skipping heading levels. The HTML Section Heading elements (Reference)
Solution:
```
<h1 class="qr-title">Improve your front-end skills by building projects</h1>
```
I hope those tips will help you.

Good job, and happy coding!
Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord