@Jd536
Posted
Hey Kirsten,
Great start! β¨
The Background-colors match the design
Here are a few things you could improve:
-
Make sure the font-family match the Design. The style-guide file suggested Outfit Get Started with the Google Fonts API
-
Set the font size to 15px (no big deal, but it's always best to follow design recommendation).
-
Instead of using div around main class, you could use main for accessibility purposes.
-
The last thing and the most important is that your solution is not responsive. The QR-code is not visible on mobile. Kindly update your code to match the mobile design. π Resource.Responsive design
I hope this is helpful. Feel welcome to let me know if you have any questions.
Have an excellent weekend. β
Marked as helpful
@ofthewildfire
Posted
@Jd536 Hi, thank you so much for your feedback, I was not aware I had to make both though, so thanks for that, I had picked this one because I don't know how to work with responsive and the little tag said it was good for a "first" without knowledge of responsive :) it's a little far in my lessons so it will be a while before I can update the code.
I will update the font and sizing ASAP though, again, thank you so much! Appreciate it.