Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR Code Component With React and Tailwind CSS

#react#tailwind-css

@snowsneakers

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Very new to React so I wanted to do something less difficult and improve my familiarity

Community feedback

Danilo Blas 6,280

@Sdann26

Posted

Hi Patrick!

I've seen your github and you have a pretty good level, by the way here you have some errors mostly generated by the frontend mentor reports.

To remove it is quite simple, you can change <div id="root"> by <div id="root" role="main"> (adding this attribute).

Or the best option is to change <div id="root"> to <main id="root"> which is the tag to encompass the main content of your page since you should only have one <main> per page.

This can be useful in different projects if they have the same errors. Do not forget to generate a new report.

By the way a recommendation, always a REM for the font size, the reason is that it is a relative measure that depends on the font-size of the html that by default is 16px and at the time of modifying this it changes the one of all your page likewise many libraries are using REM for which if at some moment you call elements of one or another library they are going to adapt to the size of the letter that you have placed to your page. So at least that's my recommendation if you didn't know.

I hope my comments are helpful :D!

Marked as helpful

0

@snowsneakers

Posted

@Sdann26 Thank you for the feedback Danilo! Your comments are very helpful. Much appreciated!

1

@ndro

Posted

Hi, 👏 congrats for completing the challenge

For the rounded on the white card, I think you should try rounded-2xl to look similar to the design. and add some shadow maybe.

Everything is nice! 🤘

Marked as helpful

0

@snowsneakers

Posted

@ndro Thank you for the feedback, Hendro!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord